Release v2.2.0#184
Merged
BenjaminRodenberg merged 11 commits intomasterfrom Oct 31, 2024
Merged
Conversation
* Add dockerfile used for `benjaminrodenberg/fenics` * Use `pip install --break-system-packages ...`.
* Fixes tests
* Add tests to check if SolverState stores and returns the checkpointed state correctly --------- Co-authored-by: Benjamin Rodenberg <benjamin.rodenberg@cit.tum.de>
Co-authored-by: Frédéric Simonis <simonisfrederic@gmail.com>
…ing installation (#181) * Require mpi4py < 4 --------- Co-authored-by: Benjamin Rodenberg <benjamin.rodenberg@cit.tum.de>
This was referenced Oct 25, 2024
IshaanDesai
requested changes
Oct 29, 2024
Member
IshaanDesai
left a comment
IshaanDesai
left a comment
There was a problem hiding this comment.
Code related changes make sense; the CI stuff not so much.
Contributor
IshaanDesai
approved these changes
Oct 30, 2024
Member
IshaanDesai
left a comment
IshaanDesai
left a comment
There was a problem hiding this comment.
My earlier comments have been addressed to a reasonable degree. Release is good to go 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release comes with some minor modifications to simplify the installation process and an important bugfix when subcycling is used (see #172).